StyleCoped scripts/models/*.cs

[zwrawr]

Improved Style of scripts in the models directory.

Did not rename methods/Varibles or reorder public/private

[Grenkin1988]

You are going to have so much conflicts I think :-) You should do it in smaller parts.

[svmnotn]

no conflicts if someone merges it right now ;)

[Grenkin1988]

Than everyone else would have them

[bjubes]

The code will be clean, but everyone will hate you :)

[WardBenjamin]

To be honest, I'm in favor of doing this now while it's not too, too intrusive.

The only issue I see is that in a bunch of places, there's now 4 forward slashes in comments. (i.e.: ////).

[Grenkin1988]

This is still not finished, It would be better just to force people style file when they change it.

[zwrawr]

the //// is how StyleCop wants commented out code to be

[Grenkin1988]

There should be no commented out code #440

[zwrawr]

Before i commit that , Removing commented code will be removing commented out Debug.Log/Logger.Log is that okay?

[Grenkin1988]

@zwrawr that people still discussing.

[zwrawr]

I made a branch off this and removed commented out code , will merge if people want that

[alexanderfast]

I would advise against doing this, as others have pointed out it might be problematic for other pull requests. It is much better to do cleanup in a file youre working in anyway. Preferably as a separate commit if its much, so you can look at just the diff of the other commit to see what was actually done.

If you really want to do some cleanup, then do one file at the time, try to find files that no one works in.

I appreciate the initiative though. :)

[WardBenjamin]

@zwrawr That's definitely an issue then. Is there a way to change that setting? Plus, it //// commented the actual comments people put there, which I don't like. I guess tbh those should be /**/ block comments, but still.

[alexanderfast]

There's no way to change, we can turn the rule off or leave it on. This is a good thing, cuts down on discussion. For the comments though, is it really that important? Considering what we would give up by turning if off. Everyone is used to something.

[WardBenjamin]

Alright, I'm okay with this now. Merging!