Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios 9162 update token weights for native components #288

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

idenjoe
Copy link
Contributor

@idenjoe idenjoe commented Jul 10, 2023

🎟️ Jira ticket

IOS-9162 Update token weights for components still using medium weight.

πŸ₯… What's the goal?

Change all the existing components still using the medium weight with new tokens.

🚧 How do we do it?

  1. Changed NovumBarButtonItem badgeTextAttributes from medium to indicator token.
  2. Changed CroutonConfig croutonOverriddenSizes to use link token instead medium weight.
  3. Changed UINavigationBar+Mistica misticaTitleTextAttributes to use navigationBar token instead of medium weight.
  4. Changed title and description labels in LoadErrorViewController to use cardTitle token and regular weight instead of medium weight.
  5. Changed MisticaAppearance normalTextAttributes and selectedTextAttributes to use tabsLabel token instead of medium weight.
  6. Changed NavigationVew+Styleguide misticaTitleTextAttributes to use navigationBar token instead of medium weight.
  7. Changed some tests snapshots.

πŸ§ͺ How can I verify this?

You can use the following alpha.

πŸ‘ AppCenter build

qr

Copy link
Contributor

@alejandroruizponce alejandroruizponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! πŸ‘

@@ -82,15 +82,15 @@ private extension LoadErrorViewController {
}

func setUpTitleText() {
titleTextLabel.font = .textPreset4(weight: .medium)
titleTextLabel.font = .textPreset4(weight: .cardTitle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having cardTitle in ErrorViewController is weird @aweell . Could we avoid coupling the weight names with the components? Could we rename this?? (not needed right now)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it also in the emptyStateCard component, i'm thinking if it makes sense to have a generic one that covers all kind of feedbacks using a text-preset smaller than 5. If it's not needed right now can we see if other new cases fall into the same category and then change it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, not needed now but take in account to improve this ;)

@idenjoe idenjoe requested review from yceballost and removed request for aweell July 17, 2023 07:04
@yceballost yceballost requested review from aweell and removed request for yceballost July 19, 2023 10:03
@amegias amegias merged commit c926e4a into main Jul 24, 2023
3 checks passed
@amegias amegias deleted the IOS-9162_Update_token_weights_for_native_components branch July 24, 2023 06:59
tuentisre pushed a commit that referenced this pull request Jul 24, 2023
# [25.4.0](v25.3.2...v25.4.0) (2023-07-24)

### Features

* **Fonts:** IOS-9162 Update token weights for native components ([#288](#288)) ([c926e4a](c926e4a))
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 25.4.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants