-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios 9162 update token weights for native components #288
Ios 9162 update token weights for native components #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! π
@@ -82,15 +82,15 @@ private extension LoadErrorViewController { | |||
} | |||
|
|||
func setUpTitleText() { | |||
titleTextLabel.font = .textPreset4(weight: .medium) | |||
titleTextLabel.font = .textPreset4(weight: .cardTitle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having cardTitle
in ErrorViewController is weird @aweell . Could we avoid coupling the weight names with the components? Could we rename this?? (not needed right now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it also in the emptyStateCard component, i'm thinking if it makes sense to have a generic one that covers all kind of feedbacks using a text-preset smaller than 5. If it's not needed right now can we see if other new cases fall into the same category and then change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, not needed now but take in account to improve this ;)
π This PR is included in version 25.4.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
IOS-9162 Update token weights for components still using medium weight.
π₯ What's the goal?
Change all the existing components still using the medium weight with new tokens.
π§ How do we do it?
π§ͺ How can I verify this?
You can use the following alpha.
π AppCenter build