Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-10407 Update textAppBar and backgroundContainerBrand tokens #383

Merged

Conversation

alejandroruizponce
Copy link
Contributor

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-10407

πŸ₯… What's the goal?

Update the Mistica tokens, specifically the VivoNew token for the textAppBar and the backgroundContainerBrand token which can now be a gradient in O2New.

This PR is a fix of the PR generated by @yceballost but with more information and adapted to be integrated:
#380

🚧 How do we do it?

The most relevant change is the backgroundBrandContainer that when taking values of solid color and gradient in function of the skin needs to be a MisticaColor.

This change affects the cells of Lists of type boxed inversed.

Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🫢

@alejandroruizponce alejandroruizponce merged commit 24a0a7c into main Jul 12, 2024
1 check passed
@alejandroruizponce alejandroruizponce deleted the IOS-10407-Update-Mistica-token-textAppBar-in-VivoNew branch July 12, 2024 10:49
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 31.0.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants