fix: file-worker任务状态更新请求无序到达导致第三方源文件偶现分发失败 #2434 #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jsonwan
commented
Sep 13, 2023
jsonwan
commented
- 任务状态更新支持事务与写入锁定，保证多条关联数据更新的原子性；
- 优化文件下载任务表索引；
- DAO层代码全部改用声明式事务；
- 删除部分未使用的冗余代码；
- 优化file-worker线程池配置，增加监控。
jsonwan
force-pushed
the
github_fix/third_file
branch
from
212b789
to
544e686
Compare
wangyu096
requested changes
Sep 13, 2023
| @@ -58,8 +58,7 @@ public class FileSourceServiceImpl implements FileSourceService { | |||
|
|
|||
| @Autowired | |||
| public FileSourceServiceImpl(FileSourceTypeDAO fileSourceTypeDAO, | |||
| FileSourceDAO fileSourceDAO, | |||
| FileWorkerDAO fileWorkerDAO) { | |||
| FileSourceDAO fileSourceDAO, FileWorkerDAO fileWorkerDAO) { | |||
| FileWorkerDAO fileworkerDAO, | ||
| FileSourceDAO fileSourceDAO, | ||
| DispatchService dispatchService, | ||
| FileTaskDAO fileTaskDAO, FileWorkerDAO fileworkerDAO, |
| @@ -121,6 +120,7 @@ public TaskInfoDTO startFileSourceDownloadTask(String username, Long appId, Long | |||
| fileSourceId, filePathList, null); | |||
| } | |||
|
|
|||
| @Transactional(rollbackFor = {Throwable.class}) | |||
There was a problem hiding this comment.
@transactional 需要value 属性指定TransactionManager（轻量化部署不指定的情况下会报错）)
| @@ -240,50 +240,55 @@ private void notifyFileTaskStatusChangeListeners(FileTaskDTO fileTaskDTO, FileSo | |||
| } | |||
|
|
|||
| @Override | |||
| @Transactional(rollbackFor = {Throwable.class}) | |||
There was a problem hiding this comment.
@transactional 需要value 属性指定TransactionManager（轻量化部署不指定的情况下会报错）)
| @@ -51,8 +51,7 @@ public class FileSourceTaskStatusUpdater implements FileTaskStatusChangeListener | |||
|
|
|||
| @Autowired | |||
| public FileSourceTaskStatusUpdater(FileSourceTaskDAO fileSourceTaskDAO, | |||
| FileTaskDAO fileTaskDAO, | |||
| FileSourceTaskStatusChangeListener listener) { | |||
| FileTaskDAO fileTaskDAO, FileSourceTaskStatusChangeListener listener) { | |||
wangyu096
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.