feat: 容器执行支持灰度 #2903 #2918
Merged
feat: 容器执行支持灰度 #2903 #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Apr 19, 2024
| && isContainerExecuteJob(stepInstanceList, variables)) { | ||
| // 未开启"容器执行"特性的灰度,返回错误 | ||
| throw new NotImplementedException( | ||
| "ContainerExecute is not support", ErrorCode.NOT_SUPPORT_FEATURE); |
There was a problem hiding this comment.
如果某个业务先被加入灰度，产生了部分容器执行任务，再被切出了灰度，这里会导致已有的容器任务（例如定时任务）失败。
jsonwan
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需求见 #2903