Accept mail with charset not set to utf-8. #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plain and HTML views of the mail expected the mail to be encoded as utf-8. So for mail with other encoding the presentation will be messed up for characters outside the ascii-range. This is a working but crude patch since its reencodes the text to utf-8 from whatever encoding it was to start of with. so all messages are actually displayed as utf-8 messages even if you have a line like this in your message: Content-Type: text/plain; charset="iso-8859-1"
|
Thanks for the PR! small suggestion for the future: Never perform actual merges in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plain and HTML views of the mail expected the mail to be encoded as
utf-8. So for mail with other encoding the presentation will be messed
up for characters outside the ascii-range.
This is a working but crude patch since its reencodes the text to utf-8
from whatever encoding it was to start of with. so all messages are
actually displayed as utf-8 messages even if you have a line like this
in your message:
Content-Type: text/plain; charset="iso-8859-1"