LoRaWAN: support ABP activation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this nice addition. I was wondering if we should compile in the ABP parts in the .c file conditionally depending on a new Kconfig option |
|
Sure, let me refactoring and re-send PR for your review. |
End device activation support for Activation By Personalization(ABP). Default ABP is disabled, set LoRaWAN data object pAbp to true to enable ABP and device address(pDevAddr), session keys for network(pNwkSKey) and application(pAppSKey).
kuohsianglu
force-pushed
the
lorawan_abp
branch
from
fd89590
to
aea7dfa
Compare
martinjaeger
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End device activation support for Activation By Personalization(ABP). Default ABP is disabled, set LoRaWAN data object pAbp to true to enable ABP and device address(pDevAddr), session keys for network(pNwkSKey) and application(pAppSKey).
Testing with Chirpstack network server for both OTAA and ABP can work fine.