Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple commands #290

Merged
merged 52 commits into from
Mar 23, 2017
Merged

Support multiple commands #290

merged 52 commits into from
Mar 23, 2017

Commits on Mar 7, 2017

  1. Initial implementation of EventBus for multiprocess support 

    Supporting more than one "main" application and their various preStart
behaviors implies they can depend on each other. Rather than making us
responsible for creating a graph of these dependencies, all components
will publish and subscribe to events on a top-level EventBus.
    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    8e75d2e View commit details
    Browse the repository at this point in the history

  2. Implemented Watch behavior, removed Backend

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    0a7877f View commit details
    Browse the repository at this point in the history

  3. Implemented Check behavior, split from Service

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    a6199cb View commit details
    Browse the repository at this point in the history

  4. Implement config parsing for Services

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    5d10b42 View commit details
    Browse the repository at this point in the history

  5. Run() method in Runners need to loop

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    40ad7fc View commit details
    Browse the repository at this point in the history

  6. Use entire Event and not just code for basis of Run() switch

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    2405ec8 View commit details
    Browse the repository at this point in the history

  7. No need to both select and switch on Runner.Rx channels

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    cb93243 View commit details
    Browse the repository at this point in the history

  8. Use startupEvent in Runner rather than new Event when possible

    @tgross
    tgross committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    b3e115b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2017

  1. Make Command take a time.Duration and not parse the duration itself

    @tgross
    tgross committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    6701020 View commit details
    Browse the repository at this point in the history

  2. [wip] move tasks and coprocesses into service package as config-only

    @tgross
    tgross committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    010c4b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2017

  1. Tighten up tests for arg parsing

    @tgross
    tgross committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    4d7694b View commit details
    Browse the repository at this point in the history

  2. fix-up error messages and tests for checks/watches

    @tgross
    tgross committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    fe4d1ba View commit details
    Browse the repository at this point in the history

  3. correctly parse timeout duration for Service.exec

    @tgross
    tgross committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    e9e68f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2017

  1. Get watch, service, and check unit tests running after update

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    d5d633f View commit details
    Browse the repository at this point in the history

  2. Don't re-append WatchConfig or CheckConfig to list after validation

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    14eda5e View commit details
    Browse the repository at this point in the history

  3. port sensors to use new EventBus

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    73da49d View commit details
    Browse the repository at this point in the history

  4. add Error event for instrumenting Command tests and get those working

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    4a8348c View commit details
    Browse the repository at this point in the history

  5. got all config parsing tests passing

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    ebb1124 View commit details
    Browse the repository at this point in the history

  6. [wip commit] getting config parsing working again

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    ed0ef0e View commit details
    Browse the repository at this point in the history

  7. make the linter a bit happier

    @tgross
    tgross committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    e33a708 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2017

  1. account for nil preStart, pre/postStop, telemetry

    @tgross
    tgross committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    72cf04b View commit details
    Browse the repository at this point in the history

  2. got most of signal unit tests working again

    @tgross
    tgross committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    4d5266d View commit details
    Browse the repository at this point in the history

  3. fix SIGTERM handler test by removing extra lock around Shutdown

    @tgross
    tgross committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    54a0dbb View commit details
    Browse the repository at this point in the history

  4. restore stop timeout behavior by killing all Service processes

    @tgross
    tgross committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    22b03e0 View commit details
    Browse the repository at this point in the history

  5. remove unused Pollable code

    @tgross
    tgross committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    f1a5d4d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2017

  1. minimize race for end of exec and closing logger's io.WriteCloser

    @tgross
    tgross committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    9ee9140 View commit details
    Browse the repository at this point in the history

  2. add wait for on-stopping event (preStop) to Service and wire-up confi… 

    …gs for it
    @tgross
    tgross committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    8aa460e View commit details
    Browse the repository at this point in the history

  3. implement NewXXXConfig for preStart/preStop/postStop, needs tests

    @tgross
    tgross committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    6c4d8e3 View commit details
    Browse the repository at this point in the history

  4. fix broken signal test

    @tgross
    tgross committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    2f395cb View commit details
    Browse the repository at this point in the history

  5. make golint happy

    @tgross
    tgross committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    132d1a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. need a way to stop containerpilot itself

    @tgross
    tgross committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    9bce4af View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2017

  1. remove unused Service field and allow for nil exec

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    83b539a View commit details
    Browse the repository at this point in the history

  2. add fmt.Stringer implementation to Check and Watch

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    31787de View commit details
    Browse the repository at this point in the history

  3. remove tasks/coprocesses/prestart/poststop/prestop in lieu of services

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    63672fe View commit details
    Browse the repository at this point in the history

  4. ensure unit testing of service config is comprehensive

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    687c568 View commit details
    Browse the repository at this point in the history

  5. testing infrastructure cleanup

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    67fdf6a View commit details
    Browse the repository at this point in the history

  6. add missing but unused struct field to checks.Config, log cleanup

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    155af3f View commit details
    Browse the repository at this point in the history

  7. fix checks so they update Service.Status via event

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    5bcd063 View commit details
    Browse the repository at this point in the history

  8. allow for nil exec in Service to accomodate advertising telemetry end… 

    …point
    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    3009ad8 View commit details
    Browse the repository at this point in the history

  9. checks need to halt when service fires Stopped event

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    330253a View commit details
    Browse the repository at this point in the history

  10. move ref to log WriteCloser into Command so it's not dropped after ex… 

    …ec ends

includes a lot of integration test cleanup around logging
    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    3338d0a View commit details
    Browse the repository at this point in the history

  11. wait for EventBus shutdown to finish on Reload

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    a3cc9d7 View commit details
    Browse the repository at this point in the history

  12. minor logging cleanups

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    0ed0c82 View commit details
    Browse the repository at this point in the history

  13. periodic services need timeout to match freq, harden test_tasks

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    9ac2f8c View commit details
    Browse the repository at this point in the history

  14. separate event bus reload from shutdown/wait

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    81730a2 View commit details
    Browse the repository at this point in the history

  15. remove sighup-in-prestart test because we've changed the behavior

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    28ff642 View commit details
    Browse the repository at this point in the history

  16. disambiguate watch vs service logs

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    a917678 View commit details
    Browse the repository at this point in the history

  17. make sure we always clean up our processes even on cancel

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    7d5ff2c View commit details
    Browse the repository at this point in the history

  18. avoid deadlock in reloading by moving reload up to main loop

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    e5fe99b View commit details
    Browse the repository at this point in the history

  19. give periodic task integration test timing a little more wiggle room

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    98496ed View commit details
    Browse the repository at this point in the history

  20. move coprocess test config into fixture so we can safely rewrite it

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    fd05aad View commit details
    Browse the repository at this point in the history

  21. split EventBus to its own file, clean up comments and docstrings

    @tgross
    tgross committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    182057e View commit details
    Browse the repository at this point in the history