Eliminate sources of test flakiness in TestServiceRunPeriodic #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @cheapRoc in #300 (comment), this PR should eliminate the flakiness of
TestServiceRunPeriodic.Rather than testing for a narrow number of task executions, which is susceptible to lots of little timing problems like GC or context switches in the environment, I'm testing for a maximum number of test executions only, and testing that we don't see any failures from time-outs.
I've also cleaned up a bit of cruft left over from my work re-writing tests in #290