Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing schemas for some columns in a table #68

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

suvayu
Copy link
Member

@suvayu suvayu commented Aug 7, 2024

Related issues

Closes #67

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@abelsiqueira abelsiqueira mentioned this pull request Aug 7, 2024
4 tasks
@suvayu
Copy link
Member Author

suvayu commented Aug 7, 2024

I can't replicate this locally:

Test Summary:              | Pass  Total  Time
Test convenience functions |    5      5  7.4s
Test Summary:     | Pass  Total  Time
Parsing utilities |   12     12  6.7s
Test Summary:             | Pass  Total  Time
Follow references in JSON |    4      4  1.1s
Test Summary: | Pass  Total  Time
Utilities     |    9      9  0.3s
Test Summary: | Pass  Total   Time
Read CSV      |   23     23  16.4s
Test Summary:    | Pass  Total  Time
Set table column |    7      7  5.7s
     Testing TulipaIO tests passed

The error is also a bit strange:

Execute of query "DESCRIBE rep_periods_mapping" failed: Catalog Error: Table with name rep_periods_mapping does not exist!
  Did you mean "pg_proc"?

I don't no where pg_proc could come from.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (67a2d37) to head (5d9a148).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   68.40%   68.86%   +0.46%     
==========================================
  Files           7        7              
  Lines         269      273       +4     
==========================================
+ Hits          184      188       +4     
  Misses         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@datejada datejada merged commit 257e3a8 into TulipaEnergy:main Aug 7, 2024
6 checks passed
@suvayu suvayu deleted the schema branch August 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept user options
2 participants