Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analy and assist in list of default false positives #35

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add analy and assist in list of default false positives #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions falsepositives.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ package goaway

// DefaultFalsePositives is a list of words that may wrongly trigger the DefaultProfanities
var DefaultFalsePositives = []string{
"analy", // analysis, analytics
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this one could probably be abused (even if the proper way to type it would be anally), but we'd have to add analyz for analyze, analyt for analytics and analys for analysis, so I guess we'll just go with analy as you've suggested.

Ultimately, users are free to provide their own list of false positives, so it shouldn't be too much of a big deal.

"arsenal",
"assassin",
"assaying", // was saying
"assert",
"assign",
"assimil",
"assist",
"associat",
"assum", // assuming, assumption, assumed
"assur", // assurance
Expand Down