Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "button" to false positives #68

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

imran-salim
Copy link
Contributor

@imran-salim imran-salim commented Nov 15, 2023

Summary

When censoring the string "button", the profanity detector censors a substring which results in "****on".

Fixes #69

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

goaway_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bd5b9a) 100.00% compared to head (897c49d) 100.00%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          191       191           
=========================================
  Hits           191       191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN merged commit f5d608f into TwiN:master Dec 28, 2023
2 checks passed
@TwiN TwiN added the bug Something isn't working label Dec 28, 2023
@imran-salim imran-salim deleted the false-positive-button branch December 28, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: "button"
3 participants