feat: check if maxmind_license is set before updating db

TwistTheNeil · Oct 29, 2023 · dbd6ef2 · dbd6ef2
1 parent dd058cc
commit dbd6ef2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/internal/maxmind/Maxmind.go b/internal/maxmind/Maxmind.go
@@ -65,6 +65,9 @@ func (m *DB) Close() error {
 }
 
 func (m *DB) Update() error {
+	if viper.GetString("MAXMIND_LICENSE") == "" {
+		return fmt.Errorf("Error: Can't update database when no license key is set (MAXMIND_LICENSE env var needs to be set)")
+	}
 	err := m.Close()
 	if err != nil {
 		fmt.Println("Failed to close maxmind database")

diff --git a/internal/router/router.go b/internal/router/router.go
@@ -136,7 +136,8 @@ func InitRouter() {
 		}
 		err := maxmind.GetInstance().Update()
 		if err != nil {
-			dto.Message = "error"
+			fmt.Println(err)
+			dto.Message = "error updating the maxmind database"
 			return c.JSON(http.StatusInternalServerError, dto)
 		}
 		dto.Message = "success"

diff --git a/internal/signals/TrapSignals.go b/internal/signals/TrapSignals.go
@@ -19,7 +19,10 @@ func Trap() {
 			switch <-signals {
 			case syscall.SIGUSR1:
 				fmt.Println("SIGUSR1 called. Updating maxmind db")
-				maxmind.GetInstance().Update()
+				err := maxmind.GetInstance().Update()
+				if err != nil {
+					fmt.Println(err)
+				}
 			}
 		}
 	}()