Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowJs @types error #658

Merged
merged 9 commits into from
Oct 18, 2017
Merged

Fix allowJs @types error #658

merged 9 commits into from
Oct 18, 2017

Conversation

johnnyreilly
Copy link
Member

@johnnyreilly johnnyreilly commented Oct 17, 2017

Fixes #657 #655 for TypeScript 2.4+

Added nodeResolutionAllowJs test to cover this. Use a strategy approach as the amend seems to break @types resolution in some way. Essentially, 2.4+ will run with a new approach for resolution and 2.3 will run with the existing approach.

We'll probably drop TypeScript 2.3 and below support when ts-loader 4.0 ships.

@johnnyreilly johnnyreilly changed the title added nodeResolutionAllowJs test (will fail initially) Fix allowJs @types error Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant