Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit-program-template updates #402

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Conversation

Ramin-Farhadi
Copy link
Contributor

Enhancements:

  • I changed the Preview table to save space and help users focus on editing. Now, the logic of Preview table is in xs-small-cards for a neater look.
  • To make the cards work better on different screens, I added some special styling called .custom-xs-card in the cards.scss file.
  • The layout got a makeover with Bootstrap. The main part now has 8 columns, and the sidebar has 4 columns, making everything look and work better.

@Ramin-Farhadi Ramin-Farhadi added the enhancement New feature or request label Dec 1, 2023
@Ramin-Farhadi Ramin-Farhadi requested a review from a team December 1, 2023 19:25
@Ramin-Farhadi Ramin-Farhadi self-assigned this Dec 1, 2023
@Ramin-Farhadi Ramin-Farhadi requested review from jmbarne3 and kimberspencer and removed request for a team December 1, 2023 19:25
Copy link
Contributor

@jmbarne3 jmbarne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we can lay these out as block elements within the bootstrap grid and avoid setting widths and specific heights.

Where possible, let's use the built-in bootstrap mixins, e.g. for media queries using media-breakpoint-up or media-breakpoint-down.

@Ramin-Farhadi Ramin-Farhadi merged commit 75e899d into rc-v3.4.0 Dec 4, 2023
@Ramin-Farhadi Ramin-Farhadi deleted the edit-program-template-update branch December 4, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants