Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing highlights in database + Id replaced with data-order in JS part #429

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Storing highlights in database + Id replaced with data-order in JS part #429

merged 3 commits into from
Jul 17, 2024

Conversation

Ramin-Farhadi
Copy link
Contributor

  1. I have add the logic to collect and store highlights as a json field into database. (Tested in Shell)
  2. ID was replaced with data-order to simplify everything. (tested in local.)

@Ramin-Farhadi Ramin-Farhadi added the enhancement New feature or request label Jul 17, 2024
@Ramin-Farhadi Ramin-Farhadi self-assigned this Jul 17, 2024
jmbarne3
jmbarne3 approved these changes Jul 17, 2024
View reviewed changes
core/views.py Outdated Show resolved Hide resolved
@Ramin-Farhadi Ramin-Farhadi merged commit 9a9acb6 into rc-v3.5.0 Jul 17, 2024
@Ramin-Farhadi Ramin-Farhadi deleted the highlights-sec branch July 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbarne3 jmbarne3 jmbarne3 approved these changes

Assignees

@Ramin-Farhadi Ramin-Farhadi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramin-Farhadi @jmbarne3