Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights Data Consistency Fix #435

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Highlights Data Consistency Fix #435

merged 2 commits into from
Jul 24, 2024

Conversation

jmbarne3
Copy link
Contributor

Bug Fixes:

  • Refactors the highlights code a bit to ensure we're consistently working with a Python object when working with the field.
  • The one exception to this rule is when the JSON data is written to the hidden input, it has to be escaped as a string. Once the data is loaded into the javascript in the edit screen, it is back to being a JSON object.

@jmbarne3 jmbarne3 added the bug Something isn't working label Jul 24, 2024
@jmbarne3 jmbarne3 requested a review from a team July 24, 2024 16:01
@jmbarne3 jmbarne3 self-assigned this Jul 24, 2024
@jmbarne3 jmbarne3 requested review from kimberspencer and Ramin-Farhadi and removed request for a team July 24, 2024 16:01
@jmbarne3 jmbarne3 merged commit b30d1a1 into rc-v3.5.0 Jul 24, 2024
@jmbarne3 jmbarne3 deleted the default-value-highlights branch July 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimberspencer kimberspencer kimberspencer approved these changes

@Ramin-Farhadi Ramin-Farhadi Ramin-Farhadi approved these changes

Assignees

@jmbarne3 jmbarne3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmbarne3 @kimberspencer @Ramin-Farhadi