UFPWriter: fix serialization of SettingFunctions #13473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13209 adds the modified settings to the UFP exports. The settings are serialized as JSON but doesn't handles the SettingFunctions. This was also reported by users in emtrax-ltd/Cura2MoonrakerPlugin#55.
Reproduction steps:: Modify a setting with a computed default, then click the icon. Slice and save the result as a .ufp file. Cura will crash with:
This patch mimics what
GcodeWriter
does, callingstr()
on the setting values.