Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tree Support Implementation #1282

Merged
merged 120 commits into from
Apr 25, 2023
Merged

New Tree Support Implementation #1282

merged 120 commits into from
Apr 25, 2023

Commits on Jul 2, 2020

  1. Implemented new tree support

    @ThomasRahm
    ThomasRahm committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    6b38494 View commit details
    Browse the repository at this point in the history

  2. Changed filename of linearAlg2D.h import to lower case.

    @ThomasRahm
    ThomasRahm committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    416b437 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Fixed support_tree_support_line_outset causing useless inital areas. … 

    …Also fixed hole detection in projectInwardsFromOutline and a few missing new lines in log messages.
    @ThomasRahm
    ThomasRahm committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    b37be4a View commit details
    Browse the repository at this point in the history

  2. Fixed crash when no support is needed.

    @ThomasRahm
    ThomasRahm committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    c94ce44 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Removed a few setting including the legacy tree support and the demo.cfg

    @ThomasRahm
    ThomasRahm committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    458b3fc View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Further removed settings. Top area is now support roof. Also fixed so… 

    …me bugs and started renaming.
    @ThomasRahm
    ThomasRahm committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f275bfd View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Smoothed branch movement and added that branches try to not move for … 

    …the amount of support roof layers if support roof is enabled, but the overhang area is to small for a roof.
    @ThomasRahm
    ThomasRahm committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    a58f515 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Reimplemented ModelVolumes to enable new features, added support for … 

    …Distance Priority and improved to model adhesion
    @ThomasRahm
    ThomasRahm committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    9ff9bc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Added support for correct handling of per mesh settings.

    @ThomasRahm
    ThomasRahm committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    12ff206 View commit details
    Browse the repository at this point in the history

  2. Reordered functions for better readability

    @ThomasRahm
    ThomasRahm committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7033244 View commit details
    Browse the repository at this point in the history

  3. Fixed progress bar jumping around and improved performance if meshes … 

    …with different mesh settings have a different height of the first overhang
    @ThomasRahm
    ThomasRahm committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    4569cd1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Multiple Bugfixes

    @ThomasRahm
    ThomasRahm committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    69917f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. small bugfix

    @ThomasRahm
    ThomasRahm committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    9fbef7c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Merge remote-tracking branch 'upstream/4.8' into tree_support_2

    @ThomasRahm
    ThomasRahm committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    1056fa0 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. A ton of bugfixes

    @ThomasRahm
    ThomasRahm committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    9b000a9 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. Merge tag '4.9.0' into tree_support_2: Updated to CuraEngine 4.9 

    Cura release 4.9.0
    @ThomasRahm
    ThomasRahm committed May 1, 2021
    Configuration menu
    Copy the full SHA
    34e396a View commit details
    Browse the repository at this point in the history

  2. Applied automated formatting, added more comments, and improved code … 

    …quality a bit
    @ThomasRahm
    ThomasRahm committed May 1, 2021
    Configuration menu
    Copy the full SHA
    089da0b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Fixed issues with non model meshes. Also fixed issues when avoidances… 

    … or similar of layer 0 are requested.
    @ThomasRahm
    ThomasRahm committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f1a413d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Merge branch '4.10' of https://github.com/Ultimaker/CuraEngine into t… 

    …ree_support_2
    @ThomasRahm
    ThomasRahm committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    d5867df View commit details
    Browse the repository at this point in the history

  2. Fixed inital layer diameter causing not precalculated avoidance radii… 

    …s to be requested
    @ThomasRahm
    ThomasRahm committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    434d355 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Removed broken "Minimum Support Floor Area" setting from TreeSupport

    @ThomasRahm
    ThomasRahm committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    1050573 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Small bug-fix regarding smoothing the tree after a branch went throug… 

    …h a small hole.
    @ThomasRahm
    ThomasRahm committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    abe4dbb View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Fixed support roof not being able to reach the buildplate when it sho… 

    …uld. Improved performance when a lot of roof areas are present.
    @ThomasRahm
    ThomasRahm committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    8e4710d View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Refactored drawAreas and moved most of the code into one of four diff… 

    …erent fuctions.
    @ThomasRahm
    ThomasRahm committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    724b687 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2021

  1. Updated to 4.12

    @ThomasRahm
    ThomasRahm committed Nov 13, 2021
    Configuration menu
    Copy the full SHA
    c218041 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Fixed missing tips when minimum z distance is small, improved tip pla… 

    …cement and improved performance in some cases.
    @ThomasRahm
    ThomasRahm committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    8b32357 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Fixed tree support generating hanging in certain situations

    @ThomasRahm
    ThomasRahm committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    d5aad83 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Added minimum tip radius and interface preference settings. Added tip… 

    … becoming roof when tip larger than minimum roof area. Some bugfixes.
    @ThomasRahm
    ThomasRahm committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    48200dc View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Update to 4.13

    @ThomasRahm
    ThomasRahm committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b5ac583 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Improved tip placement when tip radius is large

    @ThomasRahm
    ThomasRahm committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    143714a View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. Fixed branches generating not supporting overhang when z overrides xy… 

    … distance
    @ThomasRahm
    ThomasRahm committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    8a75061 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Fixed dropping down of non-gracious support areas

    @ThomasRahm
    ThomasRahm committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    346128e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge branch '5.0' of https://github.com/Ultimaker/CuraEngine into tr… 

    …ee_support_2

# Conflicts:
#	src/TreeSupport.cpp
#	src/TreeSupport.h
    @ThomasRahm
    ThomasRahm committed May 24, 2022
    Configuration menu
    Copy the full SHA
    d4a5e83 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Updated to 5.0. Fixed some potential bugs. Split ModelVolumes into it… 

    …s own files. Improved spelling and documentation.
    @ThomasRahm
    ThomasRahm committed May 25, 2022
    Configuration menu
    Copy the full SHA
    07e92a3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Changed order of parallel_for_nowait and parallel_for to fix compilat… 

    …ion issues under linux
    @ThomasRahm
    ThomasRahm committed May 30, 2022
    Configuration menu
    Copy the full SHA
    5d684ce View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Added Feature to limit reach of each branch and another to ignore pre… 

    …fering the buildplate over flat parts of the model. Also fixed a few bugs.
    @ThomasRahm
    ThomasRahm committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d7769a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Remove parallel for nowait before update to 5.1

    @ThomasRahm
    ThomasRahm committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4f8c494 View commit details
    Browse the repository at this point in the history

  2. Merge tag '5.1.0' into tree_support_2

    @ThomasRahm
    ThomasRahm committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    bdcdb3a View commit details
    Browse the repository at this point in the history

  3. Update to 5.1. Also a small potential bugfix and minor restructuring.

    @ThomasRahm
    ThomasRahm committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    11742dd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Fixed wrong placement of branches on buildplate when using rest on an… 

    …y surface preference
    @ThomasRahm
    ThomasRahm committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    26ebae0 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Merge remote-tracking branch 'upstream/5.2' into tree_support_2 

    # Conflicts:
#	include/TreeSupport.h
#	src/TreeSupport.cpp
    @ThomasRahm
    ThomasRahm committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ecd1ff1 View commit details
    Browse the repository at this point in the history

  2. Update to Cura 5.2 and implement support_tree_max_diameter.

    @ThomasRahm
    ThomasRahm committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a5406e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Fixed issue preventing slicing of multiple models at the same time.

    @ThomasRahm
    ThomasRahm committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    034fe14 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge remote-tracking branch 'upstream/main' into tree_support_2 

    # Conflicts:
#	include/TreeModelVolumes.h
#	src/TreeModelVolumes.cpp
    @ThomasRahm
    ThomasRahm committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e535e04 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Removed usage of outer_poly_first_layer

    @ThomasRahm
    ThomasRahm committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    553a012 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Revert "Merge pull request Ultimaker#1738 from Piezoid/area_deviation… 

    …_scaling"

This reverts commit 1adf212, reversing
changes made to 1363b81.
    @rburema
    rburema committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    70b4fbf View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Merge branch '5.2' into xmas_alpha

    @rburema
    rburema committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    381c257 View commit details
    Browse the repository at this point in the history

  2. Revert "Merge remote-tracking branch 'upstream/main' into tree_suppor… 

    …t_2"

This reverts commit e535e04, reversing
changes made to 034fe14.
    @rburema
    rburema committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fa11a4b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. New Tree Support: Quick refactors (except the big class). 

    part of CURA-9879
    @rburema
    rburema committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    a275e9d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Sync workflows from main 

    Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ccd74e0 View commit details
    Browse the repository at this point in the history

  2. Use 5.3.0-alpha dependencies 

    Revert before merging to main

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    296d38d View commit details
    Browse the repository at this point in the history

  3. Use latest Arcus 

    Revert before merging to main

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    958bb86 View commit details
    Browse the repository at this point in the history

  4. Use PUBLIC targets for deps in _CuraEngine 

    Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    80e50f2 View commit details
    Browse the repository at this point in the history

  5. Use range-v3 instead of std 

    Mac is being Mac again, also the
range-v3 library is used consistently
throughout the rest of the code

Contributes to CURA-9879
    @jellespijker
    jellespijker committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    64e626d View commit details
    Browse the repository at this point in the history

  6. New Tree Support: Refactors part II. 

    Put code in our code style -- including moving comments around, for better readability so definitely not all that is said there is mine ;-)

part of CURA-9879
    @rburema
    rburema committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2772aa8 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Fix xy_distance overriding overhangs when the overhang angle is smallish

    @ThomasRahm
    ThomasRahm committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    30d28cd View commit details
    Browse the repository at this point in the history

  2. New Tree Support: Refactors part III. 

    Put code in our code style -- including moving comments around, for better readability so definitely not all that is said there is mine ;-) -- Includes workaround for Mac compiler bug stumbled into in last commit.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9e1eb70 View commit details
    Browse the repository at this point in the history

  3. Switch back to the original 'pass-by-copy' design. 

    Pass sby reference was erronously introduced by refactoring.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b734714 View commit details
    Browse the repository at this point in the history

  4. Fix xy_distance overriding overhangs when the overhang angle is small… 

    …ish.

Manually cherry picked for CURA-9879 (git gave a bit of a mess when git cherry-pick was run...)
    @ThomasRahm @rburema
    ThomasRahm authored and rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8b9c8ac View commit details
    Browse the repository at this point in the history

  5. Small refactor: Break some more comments up into lines. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    cf52880 View commit details
    Browse the repository at this point in the history

  6. Small refactors (mostly re-lined comments). 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2a25383 View commit details
    Browse the repository at this point in the history

  7. Forgot to rename this instance of mesh for the apple-clang workaround. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ace3dba View commit details
    Browse the repository at this point in the history

  8. Refactor: Use 'using' to abreviate often used types. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    92e39af View commit details
    Browse the repository at this point in the history

  9. Minimize use of (implict) sqrt operations. 

    Will not do that much, but standard in the rest of the code.

part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8ce602f View commit details
    Browse the repository at this point in the history

  10. Replaced some of the more common magic numbers with constexprs. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7427d77 View commit details
    Browse the repository at this point in the history

  11. Resolve temporary comments made during review. 

    part of CURA-9879
    @rburema
    rburema committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    885fe03 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. 'Workaround' for crash with tree-branch-pref set to 'flat surfaces'. 

    Added a note as well. I have no idea why the (in context) equivalent (even when the static_cast<size_t> is replaced by a simple cast to int) statement, using iota, doesn't work, but this does. It may just expose another bug, but best not to take the risk right now.

part of CURA-9879
    @rburema
    rburema committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    a0dd35d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Fix for inital layer diameter not working when rest preference is on … 

    …any flat surface
    @ThomasRahm
    ThomasRahm committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    e81807b View commit details
    Browse the repository at this point in the history

  2. Undo small part of refactor that was causing issues. 

    It (moving the area-calculation to outside of the loop) _shoulnd't_ have caused issues (indicating that there's probably some deadlock possibility in the code as-is), but it _did_, so undo this part (for now).

part of CURA-9879
    @rburema
    rburema committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    3c41803 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. Fix mistakenly always requesting regular avoidance and fix slicing no… 

    …t terminating sometimes when limit branch reach is active
    @ThomasRahm
    ThomasRahm committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    201a12d View commit details
    Browse the repository at this point in the history

  2. Fix potential issue causing to buildplate branches merging with to mo… 

    …del branches to have sudden differences in radius
    @ThomasRahm
    ThomasRahm committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    4d65ae7 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge remote-tracking branch 'upstream/CURA-9879_a_tree_by_xmas' into… 

    … tree_support_2_refactored

# Conflicts:
#	src/TreeModelVolumes.cpp
#	src/TreeSupport.cpp
    @ThomasRahm
    ThomasRahm committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    6649125 View commit details
    Browse the repository at this point in the history

  2. Fix bug in getNextPointWithDistance and fix bug when subtracting line… 

    …s from areas when handling interface preference
    @ThomasRahm
    ThomasRahm committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    1724f67 View commit details
    Browse the repository at this point in the history

  3. Added comment explaining why a refactor has caused unintentional issu… 

    …es in the past
    @ThomasRahm
    ThomasRahm committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    6217ebf View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Possible fix for "Floating islands inside of support"

    @ThomasRahm
    ThomasRahm committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    8bd759a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Fix potential edge case: All but one of empty list.

    @rburema
    rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    99ca0f9 View commit details
    Browse the repository at this point in the history

  2. take disallowed areas into account when printing tree support

    @BagelOrb @rburema
    BagelOrb authored and rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a0d1e3a View commit details
    Browse the repository at this point in the history

  3. feat: settings.get<Polygons>

    @BagelOrb @rburema
    BagelOrb authored and rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d51bfc0 View commit details
    Browse the repository at this point in the history

  4. Moved PropertyAreasX definitions to where they're used.

    @rburema
    rburema committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    369c74d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge remote-tracking branch 'upstream/CURA-9879_a_tree_by_xmas' into… 

    … tree_support_2_refactored
    @ThomasRahm
    ThomasRahm committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9675cde View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Fix regression causing some tips to not generate

    @ThomasRahm
    ThomasRahm committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    f3975c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Ensure trees never rest on support blocker

    @ThomasRahm
    ThomasRahm committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    1d62038 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Fix unexpected behaviour of tip generation when support distance prio… 

    …rity is xy overrides z
    @ThomasRahm
    ThomasRahm committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2e5515d View commit details
    Browse the repository at this point in the history

  2. Fix branches that are larger than their collision radius getting unne… 

    …cessarily close to the model, causing the branch to deform
    @ThomasRahm
    ThomasRahm committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f3c1eb2 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Fix bug caused by previous commit

    @ThomasRahm
    ThomasRahm committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    139afd1 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Revert "Revert "Merge remote-tracking branch 'upstream/main' into tre… 

    …e_support_2""

This reverts commit fa11a4b
    @ThomasRahm
    ThomasRahm committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5a25ed2 View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Merge pull request Ultimaker#1738 from Piezoid/area_d… 

    …eviation_scaling""

This reverts commit 70b4fbf.
    @ThomasRahm
    ThomasRahm committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9ac75a4 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tree_support_2 

    # Conflicts:
#	.github/workflows/unit-test.yml
#	conandata.yml
#	src/support.cpp
    @ThomasRahm
    ThomasRahm committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c8838e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Reworked support roof generatrion for tree supports

    @ThomasRahm
    ThomasRahm committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    36a4c42 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Fix bug introduced with previous commit, causing support roof that wa… 

    …s replaced with support to be not supported by trees
    @ThomasRahm
    ThomasRahm committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    bd1516a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge branch 'main' into CURA-10415_update_tree

    @rburema
    rburema committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2cde161 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into CURA-10415_update_tree

    @rburema
    rburema committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bde1bea View commit details
    Browse the repository at this point in the history

  3. Fix merge main into tree-support 2.0 branch. 

    part of CURA-10415
    @rburema
    rburema committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    aee2cd0 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Error handling for a small rounding error that may cause small roof a… 

    …reas to be not supported. Also some small tweaks that maybe could prevent the same issue.
    @ThomasRahm
    ThomasRahm committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f39362d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_u… 

    …pdate_tree
    @rburema
    rburema committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ddbcdd1 View commit details
    Browse the repository at this point in the history

  3. Fix divide by zero errors when xy-dist = 0. 

    part of CURA-10415
    @rburema
    rburema committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1a681df View commit details
    Browse the repository at this point in the history

  4. Fix roof being not supported by trees

    @ThomasRahm
    ThomasRahm committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ad06a7a View commit details
    Browse the repository at this point in the history

  5. Small improvement of previous fix

    @ThomasRahm
    ThomasRahm committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f2d4835 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_u… 

    …pdate_tree
    @rburema
    rburema committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d63fb22 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Fix one layer tall trees being removed

    @ThomasRahm
    ThomasRahm committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    854fe71 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Fixed tip placement issue, causing not supported roof lines

    @ThomasRahm
    ThomasRahm committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d046eaf View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Fix missing support for one roof line

    @ThomasRahm
    ThomasRahm committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f20f751 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge remote-tracking branch 'trahm/tree_support_2' into CURA-10415_u… 

    …pdate_tree
    @rburema
    rburema committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    6706feb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Merge branch 'main' into CURA-10415_update_tree 

    # Conflicts:
#	include/TreeModelVolumes.h
#	include/TreeSupport.h
    @casperlamboo
    casperlamboo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d8e6992 View commit details
    Browse the repository at this point in the history

  2. Speed-up (+fix) for 'safeOffset' function. 

    Make the minimum increase per step configurable via the class. Set to 1/2 line-width in general. Also fix for negative offset values, which this was used with all the time, which my earlier div-by-0 stopgap-fix didn't take into account.

CURA-10464
    @rburema
    rburema committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cabefc6 View commit details
    Browse the repository at this point in the history

  3. Speedup of SafeOffsetInc function. 

    Also don't rely on fudge-length anymore, make dependant on 1/2 line-width. I don't think this function is supposed to take negative offsets, like the other one, but please check my assumption in review.

CURA-10464
    @rburema
    rburema committed Apr 5, 2023
    1 Configuration menu
    Copy the full SHA
    0670225 View commit details
    Browse the repository at this point in the history

  4. Decrease verices per 'circle' (TreeSupport 2.0) 

    It doesn't really matter that much that the branches are circular, as long as they are circular 'enough'. Given the gigantic number of branches a model may have just under a large overhang, unioning these circles takes a long time.

CURA-10464
    @rburema
    rburema committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    63109db View commit details
    Browse the repository at this point in the history

  5. Unioning many (often small) circles took too long. Fix that. 

    The cipper union algorithm seems to be written for a small number of complex polygons, rather than a large number of simple ones. This workaround seems to work very well in case there is, say, a large number of mostly overlapping circles that need to be unioned that where added to a single Polygons object.

CURA-10464
    @rburema
    rburema committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    56d3fe6 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Modernize: Partition via ranges. 

    CURA-10464

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
    @rburema @casperlamboo
    rburema and casperlamboo authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    fd177af View commit details
    Browse the repository at this point in the history

  2. Put back as for-loop, but reserve sizes beforehand. 

    CURA-10464
    @rburema
    rburema committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    fd0dfbc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'CURA-10415_update_tree' into CURA-10464_speedy_tree

    @rburema
    rburema authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    19de6e8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request Ultimaker#1873 from Ultimaker/CURA-10464_speedy_tree 

    [CURA-10464] Tree Support 2.0 speed-ups
    @rburema
    rburema authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ae7f0e2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into CURA-10415_update_tree

    @jellespijker
    jellespijker committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a7ef632 View commit details
    Browse the repository at this point in the history

  6. Add scripta log statement for exclude polys 

    Quick test to see if Scripta works on this branch

[CURA-10415]
    @jellespijker
    jellespijker committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    81b0ee5 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Someone accidentally ctrl-v'd this in here. Remove.

    @rburema
    rburema committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    58b8a80 View commit details
    Browse the repository at this point in the history

  2. Log tree_support_layer_storage 

    [CURA-10415]
    @jellespijker
    jellespijker committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    f9ce71f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Experimental hole removal for tree support

    @ThomasRahm
    ThomasRahm committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d340e68 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Improved performance of hole removal (to prevent floating lines insid… 

    …e branches). This includes porting a function from PrusaSlicer that intersects a Polygon with an AABB. Fixed a small bug related to line orientation for simulated support lines.
    @ThomasRahm
    ThomasRahm committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    e676aab View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Reworked and improved tree support tip handling for large areas when … 

    …interface is disabled.
    @ThomasRahm
    ThomasRahm committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    c3bc966 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Improved support of high density roof structures by placing tips to f… 

    …orm a lower density structure below it instead of placing tips directly below the rooflines (which could cause tip-areas to merge, causing nothing to be supported)
    @ThomasRahm
    ThomasRahm committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    bb5380a View commit details
    Browse the repository at this point in the history