Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds3502 set function check for max value has wrong comparison #647

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

rekliner
Copy link
Contributor

@rekliner rekliner commented Jul 7, 2024

should be less than max value, not greater than. In its current state it rejects all valid messages.

should be less than max value, not greater than.  In its current state it rejects all valid messages.
@UncleRus
Copy link
Owner

Nice catch :)
Thank you!

@UncleRus UncleRus merged commit df120c0 into UncleRus:master Jul 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants