fix(mpu6050): use correct variables #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`temp_offset` was written but never read from, and `accel_bias_reg` was read from, but never written to. From the code logic, they should be the same variable.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never tested the code, but while reading it, I noticed that
temp_offsetwas written to bympu6050_get_accel_offset, but its value is never read from. In the next section,accel_bias_regwas read from, but never written to. From the code logic, I assume they should be the same variable.The way the code was before, the "factory trim values" (as the comment above the code I changed describes) are being considered to be zero.