Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk key when using dimension_separator - high priority #2035

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Fix chunk key when using dimension_separator - high priority #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
669fd34
remove push
DennisHeimbigner Jul 18, 2021
6b28409
Fix chunk key when using dimension_separator
DennisHeimbigner Jul 19, 2021
8cdf594
Update RELEASE_NOTES
DennisHeimbigner Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

name: Run netCDF Tests

on: [pull_request,push]
on: [pull_request]

jobs:

Expand Down
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ This file contains a high-level description of this package's evolution. Release

## 4.8.1 - TBD

* [Bug Fix] Fix dimension_separator bug in libnczarr. See [Github #2035](https://github.com/Unidata/netcdf-c/issues/2035).
* [Bug Fix] Fix bugs in libdap4. See [Github #2005](https://github.com/Unidata/netcdf-c/issues/2005).
* [Bug Fix] Store NCZarr fillvalue as a singleton instead of a 1-element array. See [Github #2017](https://github.com/Unidata/netcdf-c/issues/2017).
* [Bug Fixes] The netcdf-c library was incorrectly determining the scope of dimension; similar to the type scope problem. See [Github #2012](https://github.com/Unidata/netcdf-c/pull/2012) for more information.
Expand Down
4 changes: 1 addition & 3 deletions libnczarr/zutil.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,13 +894,11 @@ NCZ_chunkpath(struct ChunkKey key,char dimsep)
{
size_t plen = nulllen(key.varkey)+1+nulllen(key.chunkkey);
char* path = (char*)malloc(plen+1);
char sdimsep[2];

if(path == NULL) return NULL;
path[0] = '\0';
strlcat(path,key.varkey,plen+1);
sdimsep[0] = dimsep; sdimsep[1] = '\0';
strlcat(path,sdimsep,plen+1);
strlcat(path,"/",plen+1);
strlcat(path,key.chunkkey,plen+1);
return path;
}