v4.8.1 Wellspring changes to merge back upstream #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in #1279
It looks like some vars have ndims==0 in which case the coord_dimids should not be written. Modify patch to catch those cases.
Make the data in the variable `var1` easier to compress so that the compression tests will be more robust. The zlib_ng library, for example, at level 1 does not compress a sequence of integers very well which resulted in the NetCDF-4 compressed file being larger than the uncompressed NetCDF-3 file. With the change above, the variable contains `0,0,0,1,1,1,2,2,2,...,` which compresses at level 1 and the compression test is more robust.
This PR adds the coordinate dimids to all variables; previously 1D variables did not have it. There is an issue with renaming variables with the coordinate dimid which is now exposed in this test which renames a 1D variable. Disabling parts of this test until the variable renaming code can be refactored.
…tcdf-c into v4.8.1-wellspring.wif
…nett/netcdf-c into v4.8.1-wellspring.wif
Added comment indicating that we want integer division / truncation. This should also trigger the tests to be run again; it looks like one of the tests just didn't run for some reason...
…o v4.8.1-wellspring.wif
…o v4.8.1-wellspring.wif
…move tot he new artifacts server.
…ld result in a false positive.
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Aug 24, 2021
re: Unidata#2075 The long file name fix fails when the build is manually repeated because the source file has already been renamed. Solution is to test if the dest file exists or not before doing the rename.
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Aug 25, 2021
re: Unidata#2075 The long file name fix fails when the build is manually repeated because the source file has already been renamed. Solution is to test if the dest file exists or not before doing the rename. This is apparently not a problem for automake because it uses AC_CONFIG_LINK, which uses link/copy instead of rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will eventually split into the
v4.8.1release to one side, and a subset of those changes which will go back into themaindevelopment branch after thev4.8.1release.