Don't assert if trying to open truncated file from memory. #2089
Conversation
This test currently fails. When trying to open an in-memory file which is only available partially (i.e. by accidental truncation), then the library should fail with an error in stead of an assertation, such that user code can react on this.
If a memory backed file is closed due to an aborted opening (i.e. a broken file was attempted to be opened), udata may not be set. In this case, the assertation checking for udata should not be triggered.
|
Looks ok to me. |
I think udata will be freed by the calback as soon as the callbacks are set and H5Pclose is called, so the backward link should be set up at that place. Without this change, local_image_free may be called without a proper reference to udata, which may raise an assertion: assert(udata->fapl_image_ptr == udata->app_image_ptr); while trying to open a broken file.
|
The remaining error in AppVeyour seems to be a CMake problem related to I've currently no access to a windows machine, so I don't quite know how to iterate on this further. |
|
I think I fixed the appveyor problem.
to
|
|
I am looking into the appveyor issue now, it is unrelated to your change! |
|
I believe the appveyor check may be related to how hdf5 reports it’s version information on windows vs *nix systems. I will take a look. |
|
🎉 @WardF you fixes are successful! |
This is a follow-up to Unidata/netcdf4-python#1122.
I am downloading a bunch of netCDF files which I keep in memory. I don't know if these files are complete or truncated for some reason. In order to check if those files are correct, I try to open them, but this leads to a failing assertion. This PR changes the assertion to an error condition which can be handled by the calling code.
Previously, I only got an error condition when opening a file on the filesystem, but got an assertion when opening the file from memory.