Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diskless files in mingw-w64 #2118

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Fix diskless files in mingw-w64 #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b654d4e
Open datasets in binary mode on mingw
mjwoods Sep 12, 2021
4657eef
Use binary mode for tst_inmemory in mingw
mjwoods Sep 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libsrc/memio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ readfile(const char* path, NC_memio* memio)
char* p = NULL;

/* Open the file for reading */
#ifdef _MSC_VER
#ifdef _WIN32
f = NCfopen(path,"rb");
#else
f = NCfopen(path,"r");
Expand Down Expand Up @@ -760,7 +760,7 @@ writefile(const char* path, NCMEMIO* memio)
char* p = NULL;

/* Open/create the file for writing*/
#ifdef _MSC_VER
#ifdef _WIN32
f = NCfopen(path,"wb");
#else
f = NCfopen(path,"w");
Expand Down
4 changes: 2 additions & 2 deletions nc_test/tst_inmemory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ readfile(const char* path, NC_memio* memio)
char* p = NULL;

/* Open the file for reading */
#ifdef _MSC_VER
#ifdef _WIN32
f = fopen(path,"rb");
#else
f = fopen(path,"r");
Expand Down Expand Up @@ -216,7 +216,7 @@ writefile(const char* path, NC_memio* memio)
char* p = NULL;

/* Open the file for writing */
#ifdef _MSC_VER
#ifdef _WIN32
f = fopen(path,"wb");
#else
f = fopen(path,"w");
Expand Down