Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a compile error #2261

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix a compile error #2261

merged 1 commit into from
Mar 29, 2022

Conversation

wkliao
Copy link
Contributor

@wkliao wkliao commented Mar 27, 2022

No description provided.

@wkliao wkliao requested a review from WardF as a code owner March 27, 2022 22:38
DennisHeimbigner
DennisHeimbigner approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

edwardhartnett
edwardhartnett reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that demonstrates this fix?

@wkliao
Copy link
Contributor Author

wkliao commented Mar 28, 2022

This is an error encountered at the compile time, not run time.
The codes in question are compiled when parallel I/O is enabled.
I wonder why github actions did not catch this. Most likely the
parallel I/O is not part of the "actions"?

@WardF
Copy link
Member

WardF commented Mar 28, 2022

That is quite possible; I'm going to double check that and may tweak this PR to include a one-off parallel test if need be.

Thanks!

@WardF WardF mentioned this pull request Mar 28, 2022
Merged
@WardF WardF merged commit 6649d74 into Unidata:main Mar 29, 2022
@wkliao wkliao deleted the nc4var.c branch March 29, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett left review comments

@DennisHeimbigner DennisHeimbigner DennisHeimbigner approved these changes

@WardF WardF Awaiting requested review from WardF WardF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkliao @WardF @DennisHeimbigner @edwardhartnett