Two fixes for the price of one! #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Include <getopt.h> in various utilities re: Unidata#2303 As noted, some utilities are using getopt() without including getopt.h, so add as needed. ## Turn off run_diskless2.sh when ENABLE_PARALLEL is true re: Unidata#2315 Ed notes that this test hangs when running parallel. The test is attempting to create a very large in-memory file, which is the proximate cause. But no idea what's the underlying cause.
This was referenced Apr 28, 2022
WardF
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include <getopt.h> in various utilities
re: #2303
As noted, some utilities are using getopt() without including
getopt.h, so add as needed.
Turn off run_diskless2.sh when ENABLE_PARALLEL is true
re: #2315
Ed notes that this test hangs when running parallel. The test
is attempting to create a very large in-memory file, which is
the proximate cause. But no idea what's the underlying cause.