Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unset executable flag #2745

Merged
merged 1 commit into from
Dec 12, 2023
Merged

chore: unset executable flag #2745

merged 1 commit into from
Dec 12, 2023

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Sep 3, 2023

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@DennisHeimbigner
Copy link
Collaborator

What is the point of this PR?

@akrherz
Copy link

akrherz commented Sep 3, 2023

What is the point of this PR?

To correct the file permissions of repo content...

@e-kwsm
Copy link
Contributor Author

e-kwsm commented Sep 5, 2023

Yes, the files have execute permission wrongly.

@DennisHeimbigner
Copy link
Collaborator

Does having execute permission set cause any failures or problems?

@alippai
Copy link

alippai commented Oct 10, 2023

I don't think it causes any problems. I can compare this to having a dozen unused empty files checked in a repo. It won't cause any problems, but also it's clear it shouldn't be there. This is true for the extra permissions too (git default permissions are 644, you have explicit change setting it to 755).

@akrherz
Copy link

akrherz commented Dec 8, 2023

@e-kwsm seems like this PR is awaiting you to sign the CLA, if you don't wish to do that, I'd be happy to submit this change as a PR, if you want.

@dopplershift
Copy link
Member

Honestly, there's no IP here, so the CLA isn't really necessary. @WardF feel free to merge without it.

@WardF WardF merged commit 2616e2c into Unidata:main Dec 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants