Reduce warning by changing type of NC_OBJ.id. #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Unidata#2780 As noted in the above issue, changing the NC_OBJ.id field type from size_t to int reduces irrelevant warning. There is no semantic effect since the number of distinct ids will never approach the max positive integer value. Note that this could change in the future if the id becomes more than a simple counter.
Yep, and as the public API uses |
WardF
previously approved these changes
Dec 18, 2023
|
@DennisHeimbigner I don't have a cygwin environment immediately available, but the failures in Cygwin appear to be repeatable. Any idea at a glance what might be happening? |
|
I re-ran the failed tests and they worked the second time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #2780
As noted in the above issue, changing the NC_OBJ.id field type from size_t to int reduces irrelevant warning. There is no semantic effect since the number of distinct ids will never approach the max positive integer value. Note that this could change in the future if the id becomes more than a simple counter.