Pull out FindPNETCDF CMake module
#2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - add back call to `include_directories` for PnetCDF - ensure `MPI` is found for PnetCDF with serial HDF5
LecrisUT
suggested changes
Jan 23, 2024
* main: Escape a character causing a doxygen error. Updated release notes. Added a comment block for future reference. more syntax fixes Update CMakeLists.txt CMake: Find HDF5 header we can safely include for other checks moving functions and macros to new file, lowercase things Update release notes. lowercase lower case lowercase moving functions and macros to a file CMake: Add support for UNITY_BUILD Change signature of `nczm_sortenvv` to take `size_t` Try to more consistently use `size_t` for argument of `nclistlength` Try to more consistently use `size_t` for `nclistget` index argument Include header for `size_t` in `nclist.h`
Enables potential reuse of module outside of netCDF
|
Thanks for the comments @LecrisUT, I think these are all sorted now. Merge conflicts also sorted |
Ensures pnetcdf include directory is in path
|
I think the failing test here is just a flaky remote test |
WardF
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes an issue where MPI was not linked when using pnetcdf with a serial HDF5
ENABLE_PNETCDFis true but PnetCDF not foundinclude_directorieswithtarget_link_librariesfor PnetCDFI noticed that there are three CMake variables that are now always set to the same values as each other:
ENABLE/USE/STATUS_PNETCDF.ENABLEis the user configure option, andUSEis the internal preprocessor feature macro, soSTATUS_PNETCDFcould be replaced entirely byENABLE_PNETCDF