Macros functions #2842
Merged
Macros functions #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZedThree
reviewed
Jan 18, 2024
Co-authored-by: Peter Hill <zed.three@gmail.com>
WardF
approved these changes
Jan 18, 2024
|
Awesome, thank you! |
|
Will lower-casing work? There are find functions that internally appear to be case sensitive. |
gsjaardema
added a commit
to gsjaardema/netcdf-c
that referenced
this pull request
Feb 1, 2024
The Unidata#2842 PR changed most CMake keywords to lowercase, but missed (a portion) of the UNSET commands which were changed to `UNset`. This follows on to that and pushes them all the way to `unset`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake/netcdf_functions_macros.cmakefind_*things intodependencies.cmakepartially addresses #2713