fix: exclude neovim from webpack module. #4126 #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dammit. That did not work. Need to revert this commit and the release. Probably worked cause module was available locally. |
jpoon
pushed a commit
that referenced
this pull request
Oct 14, 2019
Merged
|
Argh, I should have read the docs a bit better. https://webpack.js.org/configuration/externals/ It was true in my case, but obviously on distribution this won't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Excludes neovim module from whatever magic webpack is doing.
Which issue(s) this PR fixes
#4126
Special notes for your reviewer:
We need better tests, but I'm not even sure how we can even test this on Travis...