fix/53 Building a container image without a recipe name throws error #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbme
requested changes
Jun 18, 2024
|
Thanks for the contribution! Once you fix the typo above, could you please rebase everything in a single commit? |
…e throws error Check whether the provided recipe file exists and return error if not. Removed the line which overrides recipePath after being set.
kbdharun
force-pushed
the
fix/53-cannot-build-container-without-recipe
branch
from
a60fc67
to
224591e
Compare
kbdharun
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let the users to run
vib buildwith a recipe yml file in the folder. You can still provide the recipe name in the command, that's still the recommended way.In addition to this fix, I have also added the following validation:
It's best to catch errors early in cmd than to leave to other packages.
It is also recommended to use
errors.Is(...)instead ofos.Is(...). Refer to the following golang issuegolang/go#41122