Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmcluster not using global container registry default #1118

Closed
dctrwatson opened this issue Sep 27, 2024 · 2 comments
Closed

vmcluster not using global container registry default #1118

dctrwatson opened this issue Sep 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dctrwatson
Copy link

dctrwatson commented Sep 27, 2024 •
edited
Loading

It looks like:

operator/internal/controller/operator/factory/build/defaults.go

Line 460 in d39fc94

func addDefaultsToCommonParams(common *vmv1beta1.CommonDefaultableParams, appDefaults *config.ApplicationDefaults) {

is not applied to vmcluster like the other resources which correctly apply the global default
@f41gh7 f41gh7 added the bug Something isn't working label Sep 27, 2024
@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 27, 2024

Thanks for reporting! It'll be fixed soon.

f41gh7 added a commit that referenced this issue Sep 27, 2024
@f41gh7
build/default: properly apply global container registry for VMCluster
db072e5 
Regression was introduced at v0.48.0 release

 Related issue #1118

Signed-off-by: f41gh7 <nik@victoriametrics.com>
@f41gh7
Copy link
Collaborator

f41gh7 commented Sep 29, 2024

Issue was fixed at v0.48.3 release.

@f41gh7 f41gh7 closed this as completed Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dctrwatson @f41gh7