Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Unable to relay across Ethereum mainnet due to Gas/fee setting #1488

Closed
verabehr opened this issue Apr 23, 2024 · 3 comments
Closed

BUG: Unable to relay across Ethereum mainnet due to Gas/fee setting #1488

verabehr opened this issue Apr 23, 2024 · 3 comments
Assignees
Labels
bug Something isn't working paloma PalomaBot

Comments

@verabehr
Copy link

verabehr commented Apr 23, 2024

What is happening?

Section description Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

Messages on Ethereum are not being relayed due to this error (retrieved from message errorData). Other chains were not tested yet.

both gasPrice and (maxFeePerGas or maxPriorityFeePerGas) specified

This happens across multiple pigeons and therefore doesn't seem to be a pigeon setup issue. According to @webelf101 It looks like protocol is trying to send a tx with the option. Either gasPrice or maxFeePerGas & maxPriorityFeePerGas should be set. For ethereum mainnet, we need to masFeePerGas & maxPriorityFeePerGas because it is tx-type is 2.

Also FYI, the message was put into the queue 2 times again it seems before being processed. The second message results in a "consensus not achieved" error.

Paloma and pigeon versions and logs

Section description Write down paloma version. Write down pigeon version. Copy and paste pigeon config file as well as relevant ENV variables.

Paloma v1.13.3
Pigeon 1.11.0

https://gist.github.com/verabehr/40d03a3a0262435e920b3583d0e8b5ec

How to reproduce?

Section description Please write detailed steps of what you were doing for this bug to appear.
  1. log into the bots-server
  2. cd ~/app/curve-twap-dca-bot-script
  3. python3 bot_set_paloma.py
    This creates a message that should be relayed on Ethereum main

What is the expected behaviour?

Section description If you know, please write down what is the expected behaviour. If you don't know, that's ok. We can have a discussion in comments.

Messages are succesfully relayed by pigeons with correct EVM gas estimates.

@taariq
Copy link
Member

taariq commented Apr 24, 2024

We upgraded Geth in v1.13.2 palomachain#1137. Not sure if there were any changes that I could see with the release.

@byte-bandit
Copy link

This is related to the upgrade in Geth. I have come across this during testing, but only for the ARB chain. There's a special condition in our code that prevents manual gas calculation in that case.

@webelf101 Looks like we need to make changes depending on TX type configured for this chain. Can you confirm my assumption:

  • tx type == 0 -> only set gasPrice
  • tx type == 2 -> set maxFeePerGas & maxPriorityFeePerGas, but not gasPrice

@taariq
Copy link
Member

taariq commented Apr 24, 2024

Fixed.

@taariq taariq closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working paloma PalomaBot
Projects
None yet
Development

No branches or pull requests

4 participants