Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid gas arg combination #369

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

byte-bandit
Copy link
Collaborator

@byte-bandit byte-bandit commented Apr 24, 2024

Related Github tickets

Background

This error is ejected directly from the geth package before the transaction is even sent to the RPC. I'm not entirely sure why we're seeing this error on main net, as parameters should always be populated as necessary by default. This change adds some explicit statements to nil out any fields which may not coexist as part of the transaction options.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

@byte-bandit byte-bandit merged commit b5c052a into palomachain:master Apr 24, 2024
2 checks passed
@byte-bandit byte-bandit deleted the clohr/gas-calculation branch April 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants