Skip to content

Commit

Permalink
Remove unused FingerMajorMinorDiff setting
Browse files Browse the repository at this point in the history
  • Loading branch information
1Revenger1 committed Jul 29, 2024
1 parent d14def9 commit 44a98ba
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ The values below can be edited under Info.plist within the kext itself - these c
| `TrackpointScrollMultiplierY` | 20 | Same as the above, except applied to the Y axis |
| `TrackpointDeadzone` | 1 | Minimum value at which trackpoint reports will be accepted. This is subtracted from the input of the trackpoint, so setting this extremely high will reduce trackpoint resolution |
| `MinYDiffThumbDetection` | 200 | Minimum distance between the second lowest and lowest finger in which Minimum Y logic is used to detect the thumb rather than using the z value from the trackpad. Setting this higher means that the thumb must be farther from the other fingers before the y coordinate is used to detect the thumb, rather than using finger area. Keeping this smaller is preferable as finger area logic seems to only be useful when all 4 fingers are grouped together closely, where the thumb is more likely to be pressing down more |
| `FingerMajorMinorDiffMax` | 10 | Max difference between the width and height of a touch input before it's invalid |
| `PalmRejectionWidth` | 10 | Percent (out of 100) width of trackpad which is used for palm rejection on the left and right side of the trackpad |
| `PalmRejectionWidth` | 60 | Percent (out of 100) height of trackpad which is used for palm rejection on the left and right side of the trackpad (starting from the top) |
| `PalmRejectionTrackpointHeight` | 20 | Percent (out of 100) height of trackpad which is used for palm rejection across the top of the trackpad |
Expand Down
1 change: 0 additions & 1 deletion VoodooRMI/Configuration/RMIConfiguration.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ struct RmiConfiguration {
/* RMI2DSensor */
uint32_t forceTouchMinPressure {80};
uint32_t minYDiffGesture {200};
uint32_t fingerMajorMinorMax {10};
// Time units are in milliseconds
uint64_t disableWhileTypingTimeout {2000};
uint64_t disableWhileTrackpointTimeout {2000};
Expand Down
2 changes: 0 additions & 2 deletions VoodooRMI/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
<integer>250</integer>
<key>DisableWhileTypingTimeout</key>
<integer>250</integer>
<key>FingerMajorMinorDiffMax</key>
<integer>10</integer>
<key>ForceTouchType</key>
<integer>1</integer>
<key>ForceTouchMinPressure</key>
Expand Down
1 change: 0 additions & 1 deletion VoodooRMI/RMIBus.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ void RMIBus::updateConfiguration(OSDictionary* dictionary) {
update |= Configuration::loadUInt32Configuration(dictionary, "ForceTouchMinPressure", &conf.forceTouchMinPressure);
update |= Configuration::loadUInt32Configuration(dictionary, "ForceTouchType", reinterpret_cast<UInt32 *>(&conf.forceTouchType));
update |= Configuration::loadUInt32Configuration(dictionary, "MinYDiffThumbDetection", &conf.minYDiffGesture);
update |= Configuration::loadUInt32Configuration(dictionary, "FingerMajorMinorDiffMax", &conf.fingerMajorMinorMax);
update |= Configuration::loadUInt8Configuration(dictionary, "PalmRejectionWidth", &conf.palmRejectionWidth);
update |= Configuration::loadUInt8Configuration(dictionary, "PalmRejectionHeight", &conf.palmRejectionHeight);
update |= Configuration::loadUInt8Configuration(dictionary, "PalmRejectionTrackpointHeight", &conf.palmRejectionHeightTrackpoint);
Expand Down

0 comments on commit 44a98ba

Please sign in to comment.