Update for ggplot2 v3.5 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits triangle plot and strip plot functions into separate files. * Creates texture triangle with base R functions instead of ggtern. * Minor edits to plot documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggternoverwritesggplot2methods when attached, which is really problematic (tidyverse/ggplot2#3561 (comment)) and caused all {soils} plots to fail withggplot2 v3.5. Explored other ternary plot options (Ternary,soiltexture,ggsoiltexture, andplotrix). For now, modifiedplotrixfunctions that use base R to recreate the texture triangle. Fingers crossed forggplot2allowing more than x,y position aesthetics (tidyverse/ggplot2#3898).