Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose logs outside of the container #221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

expose logs outside of the container #221

wants to merge 2 commits into from

Conversation

mike-kaimika
Copy link
Collaborator

@mike-kaimika mike-kaimika commented Apr 22, 2022 •
edited
Loading

Takes care of issue #185

@mike-kaimika mike-kaimika mentioned this pull request Apr 22, 2022
Open
@joefutrelle
Copy link
Contributor

The local path to the logs should be yet another env var that defaults to ./logs since in prod we'll want this to go to /var/log

@mike-kaimika
Copy link
Collaborator Author

@joefutrelle Good catch. The pull request has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joefutrelle joefutrelle Awaiting requested review from joefutrelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-kaimika @joefutrelle