Make modifications list pop-up scrollable #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the modifications list pop-up would overflow beyond a short viewport and be cut off from view. By adding an explicit `max-height` we ensure that the pop- up always stays within the viewport, and with `overflow-y` we ensure that there is a scrollbar for vertical scrolling when required.
rajadain
force-pushed
the
tt/allow-scrolling-many-modifications
branch
from
509889e
to
ac9be39
Compare
mmcfarland
approved these changes
Jan 20, 2020
|
Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously the modifications list pop-up would overflow beyond a short viewport and be cut off from view. By adding an explicit
max-heightwe ensure that the pop-up always stays within the viewport, and withoverflow-ywe ensure that there is a scrollbar for vertical scrolling when required.Connects #3198
Demo
On macOS, with an implicit scrollbar:
On Windows, with an explicit scrollbar:
Testing Instructions
Check out this branch and
./scripts/bundle.sh --debugGo to :8000/ and create a new TR-55 project
Add a large number of modifications, like so:
Open the modifications pop-up on a short screen, such that you cannot see all the modifications in one screen