Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PA DEP Excel Spreadsheet to latest #3236

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Update PA DEP Excel Spreadsheet to latest #3236

merged 1 commit into from
Jan 23, 2020

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jan 22, 2020 •
edited
Loading

Overview

Previous version had some default values in other places.
This version is clean. Corresponds to https://github.com/WikiWatershed/MMW-BMP-spreadsheet-tool/blob/v1.0.0/MMW_BMP_Spreadsheet_Tool.xlsx

Connects #3235

Demo

image

This new version has been deployed "manually" to production by copying the template to all the app servers and running

$ sudo service mmw-app stop
$ sudo service mmw-app start

on them, and that has been verified by BME.

Testing Instructions

  • Check out this branch
  • Go to :8000/ and draw a shape
  • Generate a PA DEP worksheet
  • In the downloaded Excel file, go to the "Urban BMPs" tab
    • Ensure there are no pre-filled values there

@rajadain rajadain added the PA DEP Funding Source: Pennsylvania Department of Environment Protection label Jan 22, 2020
mmcfarland
mmcfarland approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Note that if you are hoping to preserve the "manual" fix until the hotfix is deployed, the autoscaling rules will terminate and bring up additional new app instances in the morning, so you'd need to reapply.

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Jan 23, 2020
@rajadain rajadain merged commit 3c4cda3 into hotfix/1.26.1 Jan 23, 2020
@rajadain rajadain deleted the tt/pa-dep-update-excel-template branch January 23, 2020 15:15
@rajadain
Copy link
Member Author

Thanks for taking a look! And for the tip. I'll go ahead and refresh those templates on production right now.

@rajadain
Copy link
Member Author

Updated manually on production again and confirmed that I'm getting the right one.

@hectcastro hectcastro mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcfarland mmcfarland mmcfarland approved these changes

Assignees

@rajadain rajadain

Labels
PA DEP Funding Source: Pennsylvania Department of Environment Protection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajadain @mmcfarland