-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zoom to AoI Button #3247
Add Zoom to AoI Button #3247
Conversation
f9e4b75
to
26a988d
Compare
b50be44
to
76aeb88
Compare
76aeb88
to
25e94b2
Compare
Tested it out, works great. Will take a look at the code shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well. Left some minor comments on the code, mainly having to do with style and convention.
25e94b2
to
5786628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks great, works well!
Overview
This PR adds a button to the map that zooms to an AOI if one exists.
Connects #3242
Demo
If there is not an AOI set, the button is hidden on the map:
Once an AOI is selected, the button shows up on the bottom right of the map:
Here's what happens when you press it:
Notes
I implemented analogous entries for the
SidebarToggleControl
control everywhere I found it, as I believe that gave the best coverage for where the new control needed to be referenced (tests, settings, compare map). However a second look on what other areas of the app should be considered from someone with broader knowledge would be great!Testing Instructions