Concord SSO for Release #3293
Merged
Concord SSO for Release #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding a second Single Sign On provider, the authentication backend and OAuth Service module are generalized with parameters that can allow them to support multiple auth providers. The client use in the views is not changed, except for one key- word argument.
Notify Rollbar on ITSI OAuth failures, convert number to string before concatenation.
Unlike ITSI, the BASE_URL and CLIENT_KEY are the same in every environment. The only secret is the SECRET_KEY, so that is the only environment variable added. The relevant secrets files have also been updated.
In preparation for adding a second Single Sign On provider, the forms and routes in the front-end are updated to take parameters for specific providers. Also rename itsi_enabled to sso_enabled. This is mainly used to hide ITSI from BiG-CZ portal. By overloading that to be a universal flag for SSO, we also exclude BiG-CZ from being able to use Concord logins. However, that is not a likely use case.
The two SSO options are moved side-by-side, with "Continue as Guest" now taking a full row underneath them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A copy of #3281 for releasing without the Custom Weather work, which is not ready to be launched.
Connects #3263
Copies #3281
Demo
To prove that the diffs of the two branches are identical:
Where 2678b4b and a90bd34 are the commits before and after #3281.