Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Weather: Rewrite Button for Scenarios #3303

Merged
merged 2 commits into from
May 4, 2020
Merged

Custom Weather: Rewrite Button for Scenarios #3303

merged 2 commits into from
May 4, 2020

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented May 1, 2020 •
edited by mmcfarland
Loading

Overview

Previously the button was associated with Current Conditions to affect the entire project. Now it is associated with editable scenarios to affect only that one.

Still uses the dummy modal. The actual modal is to be implemented in #3287.

Connects #3298

Demo

2020-04-30 23 44 54

Testing Instructions

  • Check out this branch and bundle --debug
  • Go to :8000 and log in
  • Create a MapShed project
    • Ensure there's no Custom Weather button in Current Conditions
  • Add a scenario
    • Ensure you see the Custom Weather button

@rajadain
Remove Custom Weather from Current Conditions
aef09a1
@rajadain
Add Custom Weather button as a Scenario mod
aa7f058 
Available for all customizable saved scenarios,
i.e. not Current Conditions.
@rajadain rajadain added OSI Funding Source: OSI Custom Weather Data labels May 1, 2020
@rajadain rajadain requested a review from mmcfarland May 1, 2020 03:51
mmcfarland
mmcfarland approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CWD button is showing up and hiding appropriately for scenarios and project types.

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland May 4, 2020
@rajadain
Copy link
Member Author

rajadain commented May 4, 2020

Thanks for taking a look!

@rajadain rajadain merged commit 81e8257 into develop May 4, 2020
@rajadain rajadain deleted the tt/custom-weather-rewrite-button branch May 4, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcfarland mmcfarland mmcfarland approved these changes

Assignees

@rajadain rajadain

Labels
Custom Weather Data OSI Funding Source: OSI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajadain @mmcfarland