Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shippensburg Land Projections: Proportion land cover distribution to match #3354

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

rajadain
Copy link
Member

Overview

The raw land cover numbers from the Drexel API don't match our internal NLCD 2011 numbers, and were slightly off, resulting in the user having to manually reconcile in the front-end.

Since these are future projections, the individual raw numbers are not the main feature, rather the distribution as a whole. By attuning it to the existing total, we ensure that the new distribution still reflects the forecasts but adds up to the same total, resulting in a more fluid experience.

Connects #3333

Demo

2020-07-20 10 15 11

Testing Instructions

  • Check out this PR and bundle
  • Go to :8000/ and select a shape within the DRB
  • Create a Mapshed project with it. Add changes to the area.
  • Open the Land Cover Modification dialog
  • Select a preset
    • Ensure you don't have to manually adjust the values to get the total to match

The raw land cover numbers from the Drexel API don't match
our internal NLCD 2011 numbers, and were slightly off,
resulting in the user having to manually reconcile in the
front-end.

Since these are future projections, the individual raw
numbers are not the main feature, rather the distribution
as a whole. By attuning it to the existing total, we
ensure that the new distribution still reflects the
forecasts but adds up to the same total, resulting in
a more fluid experience.
@rajadain rajadain added the OSI Funding Source: OSI label Jul 20, 2020
@rajadain rajadain requested a review from mmcfarland July 20, 2020 14:22
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - that's a really effective approach. Projected coverage did not require manual intervention in my test cases.

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Jul 20, 2020
@rajadain rajadain merged commit dfcfe0e into develop Jul 20, 2020
@rajadain rajadain deleted the tt/shippensburg-future-land-modeling-4 branch July 20, 2020 15:46
@rajadain
Copy link
Member Author

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSI Funding Source: OSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants