Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Recent Weather #3362

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Disable Recent Weather #3362

merged 1 commit into from
Jul 27, 2020

Conversation

rajadain
Copy link
Member

Overview

The NLDAS dataset is modeled, not observed, which may need further explanation to differentiate from Default Weather.

Will be enabled on staging after this for further consideration.

Connects #3361

Demo

image

Testing Instructions

  • Check out this branch and bundle
  • Open the weather data dialog
    • Ensure you don't see Recent Weather in the Available Data dropdown

@rajadain
Disable Recent Weather
c22c68c 
The NLDAS dataset is modeled, not observed, which may need
further explanation to differentiate from Default Weather.

Will be enabled on staging after this for further consideration.
@rajadain rajadain added the OSI Funding Source: OSI label Jul 27, 2020
@rajadain rajadain requested a review from mmcfarland July 27, 2020 15:13
mmcfarland
mmcfarland approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent weather is categorically removed, and other weather options remain selectable. Compare view and WQ weather label also continuing to function correctly.

@mmcfarland mmcfarland assigned rajadain and unassigned mmcfarland Jul 27, 2020
@rajadain rajadain merged commit 4f5ffdc into release/1.30.0 Jul 27, 2020
@rajadain rajadain deleted the tt/disable-recent-weather branch July 27, 2020 16:00
@rajadain
Copy link
Member Author

Thanks for taking a look, and catching the other issue!

@rajadain rajadain mentioned this pull request Aug 20, 2020
Closed
3 tasks
This was referenced Feb 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcfarland mmcfarland mmcfarland approved these changes

Assignees

@rajadain rajadain

Labels
OSI Funding Source: OSI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajadain @mmcfarland