Switch to New APIs for Front-End #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've used the taskHelper to override many of the taskModel's attributes. Now, we come across a situation where the taskName needs to be overridden. Previously we used the same endpoint to retrieve Mapshed and Subbasin results, with the difference marked via query parameter. Now we use separate endpoints. Thus, the taskHelper needs to override the taskModel's URL. Hence this overridability is added.
We switch them to have the taskType of 'api' since they'll now request /api/ rather than /mmw/ URLs. The taskNames are now specific to each model, as now they are all different endpoints than before.
While a form encoded payload still technically works, we switch to using a JSON payload for consistency. Also update some keys for the new API. Also override the task URL for subbasin runs.
This endpoint uses a separate mechanism than the rest due to a Celery group, so had been missed. This brings it in line with the standard job response of the other endpoints.
Base automatically changed from
tt/add-support-for-modifications-hashes
to
develop
March 30, 2022 20:45
emilyhu0106
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
The implementation is great! Glad to see all the pieces coming together. I encountered the same SRAT issue when I run subbasin results on HUCs in California, but things works well in the Delaware River region. I'm wondering if it is better to include something like a tooltip to inform the users that getting subbasin attenuated results is for certain regions only?
|
Thanks for reviewing! I did mention the non-California support and we are working on getting those in. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Switch the front-end to use the new public APIs.
Connects #3475
Demo
Notes
There's still a few endpoints left, will address them in a future PR.
Testing Instructions
bundle.sh --debug