Set TR-55 to use NLCD11 2011 by default #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in #3527, the NLCD19 + Soil combination for RasterGroupedCount would result in unstable values, reporting NODATA for cases that had real values. While investigating this failure, it was observed that the NLCD11 2011 + Soil combination worked correctly, as before. After conferring with clients, it was decided that TR-55 should be switched back to NLCD11 2011, until further notice. This code change allows the specification of a land layer override, but in the absence of an override will use the NLCD11 2011 layer. Since the UI does not specify any overrides, the NLCD11 2011 layer will be used for all cases.
Since we're switching TR-55 projects back to NLCD11 2011, this migration clears the results for all TR-55 projects made since 1.33.0, which switched the default to NLCD19 2019. These results will be recalculated with NLCD11 2011 whenever they are opened next in the UI.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As noted in #3527, the NLCD19 + Soil combination for
RasterGroupedCountwould result in unstable values, reporting NODATA for cases that had real values.While investigating this failure, it was observed that the NLCD11 2011 + Soil combination worked correctly, as before. After conferring with clients, it was decided that TR-55 should be switched back to NLCD11 2011, until further notice.
This code change allows the specification of a land layer override, but in the absence of an override will use the NLCD11 2011 layer. Since the UI does not specify any overrides, the NLCD11 2011 layer will be used for all cases.
Connects #3527
Demo
Notes
This bug may have implications for GWLF-E as well. Will continue investigating the original issue, but this should alleviate the issue for TR-55 users.
Testing Instructions
master, ensure you are logged in so that your work is savedvagrant ssh worker -c 'sudo service celeryd restart'