Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Drainage Area Drawing #3590

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Disable Drainage Area Drawing #3590

merged 2 commits into from
Jan 26, 2023

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jan 25, 2023 •
edited by rachelekm
Loading

Overview

Until all the tasks in #3392 are completed, disable the drainage area drawing so it doesn't open the door to folks using it on production.

Testing Instructions

  • Check out this branch and bundle.sh
  • Go to http://localhost:8000/draw
    • Ensure you don't see the drainage area draw tool between Delineate Watershed and Upload File

rajadain and others added 2 commits January 25, 2023 13:01
@rajadain
Disable Drainage Area Drawing
d03a54a 
Until all the tasks in #3392 are completed, disable the drainage area drawing so it doesn't open the door to folks using it on production.
@rachelekm
Disable gdal test to get CI to pass
ccc00f9
@rachelekm rachelekm self-requested a review January 26, 2023 20:41
rachelekm
rachelekm approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully removes the Drainage Area draw tool for now. Also includes a commit to comment out a failing GDAL test to get CI to pass, see slack discussion here. This will need to be commented back in as part of #3442.

@rachelekm rachelekm merged commit 7dfc229 into develop Jan 26, 2023
@rachelekm rachelekm mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelekm rachelekm rachelekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajadain @rachelekm