Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating migration to fix focus essence bug #714

Merged
merged 12 commits into from
Jul 11, 2024

Conversation

phildominguez
Copy link
Collaborator

@phildominguez phildominguez commented Jul 9, 2024

In this PR
  • Reworking Essence migrations to handle:
    1. Standard Essence damage migration
    2. Possible case where essence.max.max existed
    3. Previous migration may have set it to a SchemaField()
  • Adding missing awaits to setRoleValues and setFocusValues, which were causing race conditions
Testing
  • Checkout 63b8d08 (this is pre-Essence damage)
  • Create a character
  • Checkout ecbf803 (this is post-Essence damage, but the migration throws in a SchemaField)
  • No errors/Essences are fine
  • Checkout this branch (this fixes remaining migration issues)
  • No errors/Essences are fine
  • Setting Essence values and leveling for the actor should work as expected (correct values and no flickering)

@phildominguez phildominguez self-assigned this Jul 9, 2024
@phildominguez phildominguez merged commit 68564d5 into beta Jul 11, 2024
2 checks passed
@phildominguez phildominguez deleted the focus-essence-migration branch July 11, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants